fix: Polling after initial cached config #126
Conversation
| throwOnFailedInitialization = false, | ||
| skipInitialPoll = false, | ||
| } = this.configurationRequestParameters; | ||
| if (pollingIntervalMs <= 0) { |
There was a problem hiding this comment.
What's a reasonable guard/error-action to take here?
There was a problem hiding this comment.
I think we can still log the error, and then perhaps set it to the default? Alternatively, we could use an invalid polling interval to mean don't poll, which would be consistent with other SDKs
There was a problem hiding this comment.
I think setting to default is the way to go. Since there are pollAfterSuccessfulInitialization and pollAfterFailedInitialization, it doesn't make sense for an invalid argument to implicitly override the variables explicitly controlling this behaviour.
| }, | ||
| ); | ||
| const pollingCallback = async () => { | ||
| if (await this.flagConfigurationStore.isExpired()) { |
There was a problem hiding this comment.
Polling = frequent checking of the cache and, if necessary, a fetch.
typotter
changed the title
| expect(variation).toBe(pi); | ||
| }); | ||
|
|
||
| describe('Poll after successful start', () => { |
| throwOnFailedInitialization = false, | ||
| skipInitialPoll = false, | ||
| } = this.configurationRequestParameters; | ||
| if (pollingIntervalMs <= 0) { |
There was a problem hiding this comment.
I think we can still log the error, and then perhaps set it to the default? Alternatively, we could use an invalid polling interval to mean don't poll, which would be consistent with other SDKs
| }, | ||
| ); | ||
| const pollingCallback = async () => { | ||
| if (await this.flagConfigurationStore.isExpired()) { |
fixes FF-3485
labels: mergeable
Fixes: #FF-3485
Motivation and Context
The initial fetch logic of the client ignores polling configuration when the cache is unexpired.
Description
How has this been tested?
Unit tests